feat(bindings): deprecate & alias Connection::wipe - #6033
Open
jmayclin wants to merge 2 commits into
Open
Conversation
jouho
reviewed
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Remove any usage of
s2n_connection_wipefrom the rust bindings.Why
It is a scary method. An
s2n_connectionhas nearly 125 distinct members, and connection wipe will nuke some of them. This results in a state space explosion that is difficult to reason about, and makes that code path much more bug-prone.It's performance benefit is insufficient to justify it's scariness.
This is less than 1% the cost of a handshake.
How
For the rust bindings, we can remove this usage without it being a breaking change. Specifically, we can alias it to actually just call
Connection::newTesting
I previously added behavior tests in #6029. These all still pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.